Scale energy estimate by resource allocation in Teads model #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narekhovhannisyan
approved these changes
Nov 16, 2023
jmcook1186
commented
Nov 16, 2023
Signed-off-by: Joseph Cook <[email protected]>
jmcook1186
commented
Nov 16, 2023
Signed-off-by: Joseph Cook <[email protected]>
narekhovhannisyan
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
A description of the changes proposed in the Pull Request
The energy estimated by the Teads model is now scaled by the
vcpu-allocatedandvcpu-totalvalues if they are provided. For example, if only 1 out of 64 vCPUs are allocated, the energy used by the processor is scaled by 1/64. If no data is available, we assume the entire processor is being used and do not scale.Closes Green-Software-Foundation/if#271